alamb commented on PR #7727: URL: https://github.com/apache/arrow-datafusion/pull/7727#issuecomment-1747589922
> @alamb You can see my previous commits which removed the `input_schema` field. In CI, all unit tests and end-to-end tests can pass but `verify benchmark results` gets failures when deserializing protobuf to physical aggregate. > > It is because during initializing aggregate expressions for final aggregate, their constructors all needs their input data type from input schema of partial aggregate (i.e., input schema before aggregate). That is why `input_schema` is there. Sorry @viirya -- I should have looked at your comments more closely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
