viirya commented on PR #7727: URL: https://github.com/apache/arrow-datafusion/pull/7727#issuecomment-1747504076
I left a comment above to explain it and where/why it is failed in the CI pipeline. On Wed, Oct 4, 2023, 12:19 L. C. Hsieh ***@***.***> wrote: > I am far from a laptop but I tried to remove it at the first and the > schema seems necessary when deserializing from protobuf to physical > aggregate plan as aggregate expression initialization needs it. > > On Wed, Oct 4, 2023, 11:33 Andrew Lamb ***@***.***> wrote: > >> ***@***.**** approved this pull request. >> >> I think this change is fine, but I think #7741 >> <https://github.com/apache/arrow-datafusion/pull/7741> would be even >> better >> >> — >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/arrow-datafusion/pull/7727#pullrequestreview-1658254004>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AAAQZ56ZIYNPBHN4YQUSAP3X5WTXRAVCNFSM6AAAAAA5QJUG7CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJYGI2TIMBQGQ> >> . >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
