assignUser commented on code in PR #38115:
URL: https://github.com/apache/arrow/pull/38115#discussion_r1349606942
##########
r/tools/winlibs.R:
##########
@@ -18,69 +18,79 @@
args <- commandArgs(TRUE)
VERSION <- args[1]
dev_version <- package_version(VERSION)[1, 4]
-# Small dev versions are added for R-only changes during CRAN submission.
+# Small dev versions are added for R-only changes during CRAN submission
is_release <- is.na(dev_version) || dev_version < "100"
env_is <- function(var, value) identical(tolower(Sys.getenv(var)), value)
+# We want to log the message in the style of the configure script
+# not as an R error but still stop evaluation of this script.
+lg <- function(...) {
+ cat("*** ", sprintf(...), "\n")
+}
+exit <- function(...) {
+ lg(...)
+ return()
Review Comment:
wow. cmake brain took over for a bit there :facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]