paleolimbot commented on code in PR #38115:
URL: https://github.com/apache/arrow/pull/38115#discussion_r1353267716
##########
r/tools/nixlibs.R:
##########
@@ -103,6 +104,39 @@ download_binary <- function(lib) {
}
libfile <- NULL
}
+
+ # validate binary checksum for CRAN release only
+ if (dir.exists(checksum_path) && is_release ||
Review Comment:
We probably want an escape hatch here in case something happens that we
didn't anticipate. That way when a user has an issue we can say "try again with
`ARROW_R_IGNORE_CHECKSUM`" (maybe there's a better name).
##########
r/.gitignore:
##########
@@ -20,6 +20,10 @@ arrow_*.tgz
extra-tests/files
.deps
+# Checksums for the precompiled binaries will be added just before CRAN
submission
+# use `tools/update-checksums.R` to download them.
Review Comment:
Maybe add a step to PACKAGING.md so that we remember to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
