paleolimbot commented on code in PR #38115:
URL: https://github.com/apache/arrow/pull/38115#discussion_r1353823420
##########
r/tools/nixlibs.R:
##########
@@ -103,6 +104,42 @@ download_binary <- function(lib) {
}
libfile <- NULL
}
+ # Explicitly setting the env var to "false" will skip checksum validation
+ # e.g. in case the included checksums are stale.
+ skip_checksum <- env_is("ARROW_R_ENFORCE_CHECKSUM", "false")
+ enforce_checksum <- env_is("ARROW_R_ENFORCE_CHECKSUM", "true")
+ # validate binary checksum for CRAN release only
+ if (!skip_checksum && dir.exists(checksum_path) && is_release ||
+ enforce_checksum) {
Review Comment:
```suggestion
if (!skip_checksum && dir.exists(checksum_path) && is_release ||
enforce_checksum) {
```
(I forget if the linter or formatter checks these files but if it does it
might make CI start failing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
