pitrou commented on PR #34616:
URL: https://github.com/apache/arrow/pull/34616#issuecomment-1752607149
Unfortunately, the Python CI is failing. It seems that Cython 3.0.3 does
_really_ not want us to use the compile-time `IF` construct, for example:
```
FAILED: CMakeFiles/_dataset_parquet_pyx
/arrow/python/build/temp.linux-x86_64-cpython-39/CMakeFiles/_dataset_parquet_pyx
cd /arrow/python/build/temp.linux-x86_64-cpython-39 &&
/opt/conda/envs/arrow/bin/python -m cython --cplus --gdb --warning-errors -E
PARQUET_ENCRYPTION_ENABLED=1 --directive embedsignature=True --working
/arrow/python --output-file
/arrow/python/build/temp.linux-x86_64-cpython-39/_dataset_parquet.cpp
/arrow/python/pyarrow/_dataset_parquet.pyx
Error compiling Cython file:
------------------------------------------------------------
...
from pyarrow.includes.libarrow cimport *
from pyarrow.includes.libarrow_dataset cimport *
from pyarrow.includes.libarrow_dataset_parquet cimport *
from pyarrow._fs cimport FileSystem
IF PARQUET_ENCRYPTION_ENABLED:
^
------------------------------------------------------------
pyarrow/_dataset_parquet.pyx:36:0: The 'IF' statement is deprecated and
will be removed in a future Cython version. Consider using runtime conditions
or C macros instead. See https://github.com/cython/cython/issues/4310
```
https://github.com/apache/arrow/actions/runs/6435881563/job/17519423323?pr=34616#step:6:3833
@jorisvandenbossche What do you think we should do here? Pin Cython back to
2.x and refactor the encryption code later? Or refactor it right now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
