jorisvandenbossche commented on PR #34616: URL: https://github.com/apache/arrow/pull/34616#issuecomment-1752757825
Yes, we did that for the original Parquet encryption code (`python/pyarrow/_parquet_encryption.pyx`), where this works because that optional feature is fully self-contained. But here, it needs to be integrated into the existing dataset cython code. We could move the definitions of the `ParquetEncryptionConfig` and `ParquetDecryptionConfig``classes to a separate file like `_dataset_parquet_encryption.pyx`, but then we still need to use those objects conditionally in `_dataset_parquet.pyx`, since we have to unwrap those and pass the C++ objects down. Maybe we could have a dummy version of those classes (or functions that unwrap them) for the case encryption is disabled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
