jorisvandenbossche commented on PR #34616: URL: https://github.com/apache/arrow/pull/34616#issuecomment-1752716116
So the alternatives that are mentioned by the cython developers to replace `IF` are essentially: - Moving the conditional to C (https://docs.cython.org/en/latest/src/userguide/external_C_code.html#including-verbatim-c-code). I think our use case here is too complicated for that option - Use code generation (templating). There are some projects that use Tempita for this, but in general this is also not neatly integreated in cython yet (https://github.com/cython/cython/issues/2596), therefore requires some custom setup in our setup.py and has some maintenance cost (https://github.com/cython/cython/issues/4310#issuecomment-1409538833), and also defeats syntax highlighting in editors. I think the templating option could certainly _work_ (eg similarly as shown in https://github.com/cython/cython/issues/4832#issuecomment-1153533618), but so that is quite some work and has some drawbacks as well. So short-term options: pin cython <3, turn off `-Werror`, or refactor the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
