jorisvandenbossche commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1350504695
##########
python/pyarrow/_dataset_parquet.pyx:
##########
@@ -639,7 +775,9 @@ cdef class ParquetFileWriteOptions(FileWriteOptions):
write_batch_size=None,
dictionary_pagesize_limit=None,
write_page_index=False,
+ encryption_config=None,
Review Comment:
@tolleybot This is called `encryption_config`, but above in the
`_set_properties` the keyword that is being set is
`self._properties["encryption_properties"]`, so this was actually being ignored?
Also in the test_dataset_encryption.py you added, it is being passed to
`encryption_config` keyword.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
