scoder commented on PR #34616:
URL: https://github.com/apache/arrow/pull/34616#issuecomment-1753583137

   > it actually defined a `PyInit__dataset_parquet_no_encryption` (so using 
the original file name, not the module target name), and so it is not finding 
`PyInit__dataset_parquet_encryption`.
   
   Do you really need such a module? I'd just try to drop it completely. If you 
use Python references, you can just check them for `None`.
   
   > pyx file has a different name than the module target name
   
   I keep forgetting the rules and options for this, but there are definitely 
ways to define the target name. In any case, Cython needs to know the final 
module name when generating the C/C++ code because it's part of the module's 
C-API. Renaming modules between in and out is usually not a good idea because 
it adds complexity to the build and makes things harder to find.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to