jorisvandenbossche commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1351828583
##########
python/pyarrow/_dataset_parquet.pyx:
##########
@@ -639,7 +775,9 @@ cdef class ParquetFileWriteOptions(FileWriteOptions):
write_batch_size=None,
dictionary_pagesize_limit=None,
write_page_index=False,
+ encryption_config=None,
Review Comment:
> The enryption_config was not being propagated properly. I have updated the
code and included a method _set_encryption_config, to ensure the encryption
config is propagated.
Thanks. Do you have an idea why the test was passing then? (I assume because
it was ignored, it was just written without encryption, and then reading also
works fine, and it will just ignore the decryption config that was passed). Do
we have a way to update the test to ensure that it is _actually_ using
encryption?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
