jorisvandenbossche commented on PR #34616: URL: https://github.com/apache/arrow/pull/34616#issuecomment-1755157127
> Do you really need such a module? I'd just try to drop it completely. If you use Python references, you can just check them for `None`. It turns out that indeed that is not needed at all (I originally had it, because it was a cimport, because I was using a C++ type, but after making it a def, I should also have removed the pxd ..). Thanks for the help @scoder! (got it working after some more fun runtime errors, like "AttributeError: module 'pyarrow._parquet_encryption' has no attribute '__pyx_capi__'", clean rebuilds!) Version that seems to be working locally -> https://github.com/tolleybot/arrow/pull/4 > I keep forgetting the rules and options for this, but there are definitely ways to define the target name. In any case, Cython needs to know the final module name when generating the C/C++ code because it's part of the module's C-API. Renaming modules between in and out is usually not a good idea because it adds complexity to the build and makes things harder to find. AFAIK I was using standard cython features to specify the result and source file name, like `python -m cython --gdb --warning-errors --output-file .../_dataset_parquet_encryption.c .../_dataset_parquet_no_encryption.pyx`. Although, that is using `--output-file`, and probably should also set `--module-name`, which wasn't done by our cmake wrapper around `python -m cython`. (anyway, not needed here anymore, but it is a confusing error) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
