paleolimbot commented on PR #38236:
URL: https://github.com/apache/arrow/pull/38236#issuecomment-1766923182
I will also do a code review shortly, but I successfully tested (i.e., unset
ARROW_HOME, deleted any local libarrow dir, and ran `devtools::load_all()` +
`devtools::test()`) this on:
- MacOS M1
- MacOS x86/10.13
- MacOS x86/11.7
- Windows/R 4.0 (64-bit, 32-bit)
- Windows/R 4.1, 4.2, 4.3 (64-bit)
On MacOS M1 I made sure that:
- Setting ARROW_HOME with libarrow/ present results in a successful build
using the ARROW_HOME version of arrow
- Changing a C++ file and doing `devtools::load_all()` doesn't result in
recompiling everything (only the changed object + linking step)
- Changing just R code doesn't result in any recompilation
I did observe some recompilation when switching between
`devtools::load_all()` and RStudio's Install + Restart, but I don't think you
can control that...`load_all()` adds `-g -O0` and I think sometimes that
triggers recompilation that would otherwise be avoided.
On Windows I observed that there is no check for an existing `windows/`
folder: the binary is fetched every time a C++ source file changed/compilation
is attempted. I also get a warning:
```
Warning message:
In dir.create(dst_dir, showWarnings = !quietly, recursive = TRUE) :
'windows' already exists
```
Iit's pretty awesome: you can open up the project and get full autocomplete
when developing in C++ using VSCode's C++ extension (just like you would in
MacOS or Windows).
Again, code review + testing on Linux forthcoming, but in the meantime, many
many thumbs up. This is the contributor experience we have always been dreaming
of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
