WillAyd commented on PR #1093:
URL: https://github.com/apache/arrow-adbc/pull/1093#issuecomment-1762043515
Must have been misreading the benchmarks. They do show this as a pretty
sizable perf boost. Here is main:
```
2023-10-13T14:45:00-04:00
Running ./driver/postgresql/postgresql-benchmark
Run on (12 X 4700 MHz CPU s)
CPU Caches:
L1 Data 48 KiB (x6)
L1 Instruction 32 KiB (x6)
L2 Unified 1280 KiB (x6)
L3 Unified 12288 KiB (x1)
Load Average: 1.02, 0.90, 0.88
***WARNING*** CPU scaling is enabled, the benchmark real time measurements
may be noisy and will incur extra overhead.
---------------------------------------------------------------
Benchmark Time CPU Iterations
---------------------------------------------------------------
BM_PostgresqlExecute 4605464781 ns 252249371 ns 1
```
versus this PR:
```
2023-10-13T14:46:31-04:00
Running ./driver/postgresql/postgresql-benchmark
Run on (12 X 4700 MHz CPU s)
CPU Caches:
L1 Data 48 KiB (x6)
L1 Instruction 32 KiB (x6)
L2 Unified 1280 KiB (x6)
L3 Unified 12288 KiB (x1)
Load Average: 1.21, 0.93, 0.89
***WARNING*** CPU scaling is enabled, the benchmark real time measurements
may be noisy and will incur extra overhead.
----------------------------------------------------------------------------
Benchmark Time CPU Iterations
----------------------------------------------------------------------------
BM_PostgresqlExecute/iterations:1 5619839 ns 402000 ns 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
