lidavidm commented on code in PR #1093:
URL: https://github.com/apache/arrow-adbc/pull/1093#discussion_r1358712556
##########
c/driver/postgresql/postgresql_benchmark.cc:
##########
@@ -24,47 +24,56 @@
static void BM_PostgresqlExecute(benchmark::State& state) {
const char* uri = std::getenv("ADBC_POSTGRESQL_TEST_URI");
- if (!uri) {
+ if (!uri || !strcmp(uri, "")) {
Review Comment:
That's because the error needs to be released.
If we're not going to use the error, we could just not have it in the first
place (it should always be OK to pass `nullptr` to an error argument)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
