lidavidm commented on code in PR #1093:
URL: https://github.com/apache/arrow-adbc/pull/1093#discussion_r1358723081
##########
c/driver/postgresql/postgresql_benchmark.cc:
##########
@@ -24,47 +24,56 @@
static void BM_PostgresqlExecute(benchmark::State& state) {
const char* uri = std::getenv("ADBC_POSTGRESQL_TEST_URI");
- if (!uri) {
+ if (!uri || !strcmp(uri, "")) {
Review Comment:
Yeah, Dewey's original suggestion of factoring it out into a single function
would also work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
