westonpace commented on code in PR #38147:
URL: https://github.com/apache/arrow/pull/38147#discussion_r1359465060
##########
cpp/src/arrow/compute/light_array.h:
##########
@@ -183,6 +183,36 @@ class ARROW_EXPORT KeyColumnArray {
// Starting bit offset within the first byte (between 0 and 7)
// to be used when accessing buffers that store bit vectors.
int bit_offset_[kMaxBuffers - 1];
+
+ bool is_dictionary_type() const {
Review Comment:
> (If that's okay, can we add a new issue for KeyColumns to have complex
values like dictionary types?)
Is this request maybe covered by
https://github.com/apache/arrow/issues/31622 ,
https://github.com/apache/arrow/issues/32494 , or
https://github.com/apache/arrow/issues/32504 ?
Adding dictionary support for keys will be trickier than supporting large
strings unfortunately. I can give an overview of some of the steps but I don't
know that anyone has been spending a lot of time on the hash join code lately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
