pitrou commented on PR #38147:
URL: https://github.com/apache/arrow/pull/38147#issuecomment-1763032831
Yes, I agree the PR as is is a good improvement now.
What I would suggest is to update the PR title and description to better
explain the problem. Specifically, it is about slicing large string and large
binary types, with the problem being the offset size not correctly computed,
IIUC.
("uint64_t Types" in the title is really confusing as this PR has nothing to
do with 64-bit integer columns)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
