ruowan commented on code in PR #1207: URL: https://github.com/apache/arrow-adbc/pull/1207#discussion_r1361815912
########## csharp/src/Client/readme.md: ########## @@ -67,7 +67,7 @@ For example, when using the [Snowflake ADBC Go Driver](https://arrow.apache.org/ if using the default user name and password authentication, but look like ``` - adbc.snowflake.sql.account={account};adbc.snowflake.sql.warehouse={warehouse};username={user};password={password};adbc.snowflake.sql.auth_type=snowflake_jwt;adbc.snowflake.sql.client_option.auth_token={token} + adbc.snowflake.sql.account={account};adbc.snowflake.sql.warehouse={warehouse};username={user};password={password};adbc.snowflake.sql.auth_type=snowflake_jwt;adbc.snowflake.sql.client_option.jwt_private_key={token} Review Comment: According to the doc: [client option](https://arrow.apache.org/adbc/main/driver/snowflake.html) the jwt_private_key={token} should be jwt_privatge_key={private_key_file}, right? `token` here may cause some misunderstanding -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
