zeroshade commented on code in PR #1207:
URL: https://github.com/apache/arrow-adbc/pull/1207#discussion_r1362249943
##########
go/adbc/driver/snowflake/driver.go:
##########
@@ -87,8 +87,14 @@ const (
// specify the RSA private key to use to sign the JWT
// this should point to a file containing a PKCS1 private key to be
// loaded. Commonly encoded in PEM blocks of type "RSA PRIVATE KEY"
- OptionJwtPrivateKey =
"adbc.snowflake.sql.client_option.jwt_private_key"
- OptionDisableTelemetry =
"adbc.snowflake.sql.client_option.disable_telemetry"
+ OptionJwtPrivateKey = "adbc.snowflake.sql.client_option.jwt_private_key"
+ // parses an unencrypted private key in PKCS #8, ASN.1 DER form.
Specify the private key
+ // value without having to load it from the file system. Commonly
encoded in PEM blocks
+ // of type "RSA PRIVATE KEY"
+ OptionJwtPrivateKeyPkcs8Value =
"adbc.snowflake.sql.client_option.jwt_private_key_pkcs8_value"
+ // a passcode to use with JWT keys
+ OptionJwtPrivateKeyPkcs8Password =
"adbc.snowflake.sql.client_option.jwt_private_key_pkcs8_password"
+ OptionDisableTelemetry =
"adbc.snowflake.sql.client_option.disable_telemetry"
Review Comment:
Please add these new options to the `docs/source/driver/snowflake.rst` and
to the `DatabaseOptions` in the python `adbc_driver_snowflake/__init__.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
