felipecrv commented on code in PR #38252:
URL: https://github.com/apache/arrow/pull/38252#discussion_r1362921399
##########
cpp/src/arrow/array/array_run_end_test.cc:
##########
@@ -543,8 +540,9 @@ TEST_P(TestRunEndEncodedArray, Validate) {
malformed_array->data()->buffers.emplace_back(NULLPTR);
EXPECT_RAISES_WITH_MESSAGE_THAT(
Invalid,
- ::testing::HasSubstr("Invalid: Values array invalid: Expected 2
buffers in array "
- "of type int32, got 3"),
+ ::testing::HasSubstr(
+ "Invalid: Values array invalid: Invalid: Expected 2 buffers in
array "
+ "of type int32, got 3"),
Review Comment:
Isn't a bit weird to have "Invalid: " twice in the message?
##########
cpp/src/arrow/array/util.cc:
##########
@@ -347,215 +349,234 @@ static Result<std::shared_ptr<Scalar>>
MakeScalarForRunEndValue(
return std::make_shared<Int64Scalar>(run_end);
}
-// get the maximum buffer length required, then allocate a single zeroed buffer
-// to use anywhere a buffer is required
class NullArrayFactory {
public:
- struct GetBufferLength {
Review Comment:
Why delete this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
