bkietz commented on code in PR #38252:
URL: https://github.com/apache/arrow/pull/38252#discussion_r1363843832
##########
cpp/src/arrow/array/array_run_end_test.cc:
##########
@@ -543,8 +540,9 @@ TEST_P(TestRunEndEncodedArray, Validate) {
malformed_array->data()->buffers.emplace_back(NULLPTR);
EXPECT_RAISES_WITH_MESSAGE_THAT(
Invalid,
- ::testing::HasSubstr("Invalid: Values array invalid: Expected 2
buffers in array "
- "of type int32, got 3"),
+ ::testing::HasSubstr(
+ "Invalid: Values array invalid: Invalid: Expected 2 buffers in
array "
+ "of type int32, got 3"),
Review Comment:
It is, but this is the format of other child array validation failures
(since the parent array's error message contains the child array's). Possibly a
follow up issue is in order to simplify those; I think it'd be most valuable to
provide a field path to the child which failed validation and the "leaf" error
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
