bkietz commented on code in PR #38252:
URL: https://github.com/apache/arrow/pull/38252#discussion_r1363845979
##########
cpp/src/arrow/array/util.cc:
##########
@@ -347,215 +349,234 @@ static Result<std::shared_ptr<Scalar>>
MakeScalarForRunEndValue(
return std::make_shared<Int64Scalar>(run_end);
}
-// get the maximum buffer length required, then allocate a single zeroed buffer
-// to use anywhere a buffer is required
class NullArrayFactory {
public:
- struct GetBufferLength {
Review Comment:
I didn't really delete it, just refactored its logic into NullArrayFactory.
This way the code which requests preallocated zero buffer is in the same
function as the code which uses the zero buffer, which seemed more clear to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
