adamkennedy commented on code in PR #38266:
URL: https://github.com/apache/arrow/pull/38266#discussion_r1367487607
##########
java/vector/src/main/java/org/apache/arrow/vector/FixedSizeBinaryVector.java:
##########
@@ -116,6 +117,18 @@ public byte[] get(int index) {
return dst;
}
+ /**
+ * Read the value at the given position to the given output buffer.
+ * The caller is responsible for checking for nullity first.
+ *
+ * @param index position of element.
+ * @param outputBuffer the buffer to write into.
+ */
+ public void read(int index, ReusableBuffer<?> outputBuffer) {
Review Comment:
I hate to bike shed, but since these names would end up in docs,
auto-complete and API browsing...
Is "output" superfluous here, since it's a void method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
