jduo commented on code in PR #38266:
URL: https://github.com/apache/arrow/pull/38266#discussion_r1367496327
##########
java/vector/src/main/java/org/apache/arrow/vector/LargeVarBinaryVector.java:
##########
@@ -112,6 +113,20 @@ public byte[] get(int index) {
return result;
}
+ /**
+ * Read the value at the given position to the given output buffer.
+ * The caller is responsible for checking for nullity first.
+ *
+ * @param index position of element.
+ * @param outputBuffer the buffer to write into.
+ */
+ public void read(int index, ReusableBuffer<?> outputBuffer) {
+ final long startOffset = getStartOffset(index);
+ final long dataLength =
+ offsetBuffer.getLong((long) (index + 1) * OFFSET_WIDTH) - startOffset;
Review Comment:
getEndOffset() is not implemented for Large*Vectors. I can use it for
Var*Vector and write an implementation for Large*Vectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
