adamkennedy commented on code in PR #38266:
URL: https://github.com/apache/arrow/pull/38266#discussion_r1367489226
##########
java/vector/src/main/java/org/apache/arrow/vector/LargeVarCharVector.java:
##########
@@ -120,12 +123,28 @@ public byte[] get(int index) {
* @return Text object for non-null element, null otherwise
*/
public Text getObject(int index) {
- byte[] b = get(index);
- if (b == null) {
+ assert index >= 0;
+ if (NULL_CHECKING_ENABLED && isSet(index) == 0) {
Review Comment:
Won't this use of NULL_CHECKING_ENABLED completely change the behavior of
this method? Instead of returning null it will return Text(null)?
It's a matter for a different PR, but I don't see how NULL_CHECKING_ENABLED
is useful in any possible way, because it's global to all recursive
dependencies of anything using Arrow for any purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
