niyue commented on code in PR #38116:
URL: https://github.com/apache/arrow/pull/38116#discussion_r1368789081
##########
cpp/src/gandiva/expr_decomposer_test.cc:
##########
@@ -32,7 +32,7 @@ using arrow::int32;
class TestExprDecomposer : public ::testing::Test {
protected:
- FunctionRegistry registry_;
+ FunctionRegistry& registry_ = *default_function_registry();
Review Comment:
Got it. I've updated 3 places like this to use non-const pointers.
##########
cpp/src/gandiva/expression_registry.h:
##########
@@ -37,7 +38,8 @@ class GANDIVA_EXPORT ExpressionRegistry {
public:
using native_func_iterator_type = const NativeFunction*;
using func_sig_iterator_type = const FunctionSignature*;
- ExpressionRegistry();
+ ExpressionRegistry(
+ FunctionRegistry* function_registry =
gandiva::default_function_registry());
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
