niyue commented on code in PR #38116:
URL: https://github.com/apache/arrow/pull/38116#discussion_r1368799883
##########
cpp/src/gandiva/expression_registry.h:
##########
@@ -62,7 +64,7 @@ class GANDIVA_EXPORT ExpressionRegistry {
private:
static DataTypeVector supported_types_;
- std::unique_ptr<FunctionRegistry> function_registry_;
Review Comment:
I don't change this part so far, currently,
`gandiva::default_function_registry()` returns a `FunctionRegistry *` raw
pointer, and the `ExpressionRegistry` uses
`gandiva::default_function_registry()` as the default value for its internal
`function_registry_` variable. If we use `std::shared_ptr` here, do you have
any idea what we should use as the default value for `function_registry_`
variable in `ExpressionRegistry`? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
