kevingurney commented on code in PR #38531:
URL: https://github.com/apache/arrow/pull/38531#discussion_r1377912564
##########
matlab/test/arrow/array/tListArray.m:
##########
@@ -160,6 +184,81 @@ function TestErrorIfEmptyOffsets(testCase)
testCase.verifyError(fcn, "arrow:array:ListArrayFromArraysFailed");
end
+ function TestValidationModeDefault(testCase, TestValidationModeArray)
+ % Verify that the default ValidationMode value for the
+ % arrow.array.ListArray.fromArrays method is
+ % arrow.array.ValidationMode.Minimal.
+ offsets = TestValidationModeArray.Offsets;
+ values = TestValidationModeArray.Values;
+ valid = TestValidationModeArray.Valid;
+ fcn = @() arrow.array.ListArray.fromArrays(offsets, values);
+ if ~valid
Review Comment:
Oh, sorry, I made a mistake.
I forgot to add the `else` clause here to be:
```matlab
if ~valid
testCase.verifyError(fcn, "arrow:array:ValidateMinimalFailed");
else
testCase.verifyWarningFree(fcn);
end
```
Thanks for catching this. I'll update the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
