sgilmore10 commented on code in PR #38531:
URL: https://github.com/apache/arrow/pull/38531#discussion_r1377981403
##########
matlab/src/matlab/+arrow/+array/ListArray.m:
##########
@@ -100,9 +101,11 @@
ValuesProxyID=valuesProxyID, ...
Valid=validElements ...
);
-
+
proxyName = "arrow.array.proxy.ListArray";
proxy = arrow.internal.proxy.create(proxyName, args);
+ % Validate the provided offsets and values.
+ proxy.validate(struct(ValidationMode=uint8(opts.ValidationMode)));
Review Comment:
As you mentioned in the description, we should consider adding this nv-pair
to other array types. We could also add `validate` as a method as well on
`arrow.array.Array`. Just a thought - no need to do anything about this right
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
