kevingurney commented on code in PR #38531:
URL: https://github.com/apache/arrow/pull/38531#discussion_r1377995694
##########
matlab/src/matlab/+arrow/+array/ListArray.m:
##########
@@ -100,9 +101,11 @@
ValuesProxyID=valuesProxyID, ...
Valid=validElements ...
);
-
+
proxyName = "arrow.array.proxy.ListArray";
proxy = arrow.internal.proxy.create(proxyName, args);
+ % Validate the provided offsets and values.
+ proxy.validate(struct(ValidationMode=uint8(opts.ValidationMode)));
Review Comment:
Agreed. I've captured this in #38532.
##########
matlab/src/matlab/+arrow/+array/ListArray.m:
##########
@@ -100,9 +101,11 @@
ValuesProxyID=valuesProxyID, ...
Valid=validElements ...
);
-
+
proxyName = "arrow.array.proxy.ListArray";
proxy = arrow.internal.proxy.create(proxyName, args);
+ % Validate the provided offsets and values.
+ proxy.validate(struct(ValidationMode=uint8(opts.ValidationMode)));
Review Comment:
Marking this as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
