junjunjd commented on code in PR #7901:
URL: https://github.com/apache/arrow-datafusion/pull/7901#discussion_r1381244300
##########
datafusion/common/src/scalar.rs:
##########
@@ -2462,17 +2511,16 @@ impl ScalarValue {
/// This function has a few narrow usescases such as hash table key
/// comparisons where comparing a single row at a time is necessary.
#[inline]
- pub fn eq_array(&self, array: &ArrayRef, index: usize) -> bool {
- match self {
+ pub fn eq_array(&self, array: &ArrayRef, index: usize) -> Result<bool> {
+ Ok(match self {
ScalarValue::Decimal128(v, precision, scale) => {
ScalarValue::eq_array_decimal(
array,
index,
v.as_ref(),
*precision,
*scale,
- )
- .unwrap()
Review Comment:
See previous
[comment](https://github.com/apache/arrow-datafusion/pull/7901/files#r1379698814).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
