junjunjd commented on code in PR #7901:
URL: https://github.com/apache/arrow-datafusion/pull/7901#discussion_r1381231326
##########
datafusion/common/src/scalar.rs:
##########
@@ -1970,13 +2020,14 @@ impl ScalarValue {
),
},
ScalarValue::Fixedsizelist(..) => {
- unimplemented!("FixedSizeList is not supported yet")
Review Comment:
What would be the preferred way to handle unimplemented errors in
`datafusion`? There are many places where a `NotImplemented` error is returned
instead of using `unimplemented!` and panicking. IMO returning an error makes
more sense as user can choose to ignore unimplemented errors instead of
panicking and exiting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
