junjunjd commented on code in PR #7901:
URL: https://github.com/apache/arrow-datafusion/pull/7901#discussion_r1381231958
##########
datafusion/common/src/scalar.rs:
##########
@@ -1970,13 +2020,14 @@ impl ScalarValue {
),
},
ScalarValue::Fixedsizelist(..) => {
- unimplemented!("FixedSizeList is not supported yet")
+ return _not_impl_err!("FixedSizeList is not supported yet")
}
ScalarValue::List(arr) => {
let arrays = std::iter::repeat(arr.as_ref())
.take(size)
.collect::<Vec<_>>();
- arrow::compute::concat(arrays.as_slice()).unwrap()
Review Comment:
I agree this should be unreachable. I will change this back to unwrap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
