jonkeane commented on code in PR #38571:
URL: https://github.com/apache/arrow/pull/38571#discussion_r1382037196
##########
r/tools/nixlibs.R:
##########
@@ -828,10 +832,10 @@ quietly <- !env_is("ARROW_R_DEV", "true")
not_cran <- env_is("NOT_CRAN", "true")
-if (is_release) {
+if (is_release & !test_mode) {
VERSION <- VERSION[1, 1:3]
arrow_repo <- paste0(getOption("arrow.repo",
sprintf("https://apache.jfrog.io/artifactory/arrow/r/%s";, VERSION)),
"/libarrow/")
-} else {
+} else if(!test_mode) {
Review Comment:
We could also wrap this whole block in `if (!test_mode) { ... }` since we
don't want to run the actual detection yet, just check the functions. Unless
I'm missing something and we actually do want this whole main chunk to run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
