paleolimbot commented on code in PR #38571:
URL: https://github.com/apache/arrow/pull/38571#discussion_r1383288726
##########
r/tools/nixlibs.R:
##########
@@ -828,10 +832,10 @@ quietly <- !env_is("ARROW_R_DEV", "true")
not_cran <- env_is("NOT_CRAN", "true")
-if (is_release) {
+if (is_release & !test_mode) {
VERSION <- VERSION[1, 1:3]
arrow_repo <- paste0(getOption("arrow.repo",
sprintf("https://apache.jfrog.io/artifactory/arrow/r/%s";, VERSION)),
"/libarrow/")
-} else {
+} else if(!test_mode) {
Review Comment:
I think we do want the whole main chunk to run (or at least, from spending a
few minutes with the script last week it seemed like that was the original
intention). Wrapping the main logic in a function and testing that function
would be another way to go about it but I don't feel to strongly about it (I'm
just glad there's a place to put tests for these functions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
