jonkeane commented on code in PR #38571:
URL: https://github.com/apache/arrow/pull/38571#discussion_r1383378828
##########
r/tools/nixlibs.R:
##########
@@ -828,10 +832,10 @@ quietly <- !env_is("ARROW_R_DEV", "true")
not_cran <- env_is("NOT_CRAN", "true")
-if (is_release) {
+if (is_release & !test_mode) {
VERSION <- VERSION[1, 1:3]
arrow_repo <- paste0(getOption("arrow.repo",
sprintf("https://apache.jfrog.io/artifactory/arrow/r/%s";, VERSION)),
"/libarrow/")
-} else {
+} else if(!test_mode) {
Review Comment:
And just to make sure I understand: you're suggesting leaving this as is
rather than making the whole block skip while being tested.
We could also suppress the message more deeply (or even in the test script)
but IMHO both of those are harder to figure out what's up / reason about than
stopping this one bit from running during testing and producing distracting
output. But happy to change it to elsewhere if you have strong feelings about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
