niyue commented on code in PR #38632: URL: https://github.com/apache/arrow/pull/38632#discussion_r1389140177
########## cpp/src/gandiva/function_holder_maker_registry.cc: ########## @@ -0,0 +1,72 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "gandiva/function_holder_maker_registry.h" + +#include <functional> + +#include "arrow/util/string.h" +#include "gandiva/function_holder.h" +#include "gandiva/interval_holder.h" +#include "gandiva/random_generator_holder.h" +#include "gandiva/regex_functions_holder.h" +#include "gandiva/to_date_holder.h" + +namespace gandiva { + +using arrow::internal::AsciiToLower; + +FunctionHolderMakerRegistry::FunctionHolderMakerRegistry() + : function_holder_makers_(DefaultHolderMakers()) {} + +arrow::Status FunctionHolderMakerRegistry::Register(const std::string& name, + FunctionHolderMaker holder_maker) { + function_holder_makers_.emplace(AsciiToLower(name), std::move(holder_maker)); + return arrow::Status::OK(); +} + +template <typename HolderType> +static arrow::Result<FunctionHolderPtr> HolderMaker(const FunctionNode& node) { + std::shared_ptr<HolderType> derived_instance; + ARROW_RETURN_NOT_OK(HolderType::Make(node, &derived_instance)); + return derived_instance; +} Review Comment: Sure. If I make this change, we need to change some existing classes, like `LikeHolder`/`ReplaceHolder`/etc. They are `GANDIVA_EXPORT` classes, but I am not sure if they are really used externally. The code will be simpler after this refactoring. I am glad to submit another PR for this if this is desired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
