niyue commented on code in PR #38632:
URL: https://github.com/apache/arrow/pull/38632#discussion_r1389140695
##########
cpp/src/gandiva/function_registry.cc:
##########
@@ -109,11 +109,35 @@ arrow::Status FunctionRegistry::Register(const
std::vector<NativeFunction>& func
return Status::OK();
}
+arrow::Status FunctionRegistry::Register(
+ NativeFunction func, void* c_function_ptr,
+ std::optional<FunctionHolderMaker> function_holder_maker) {
+ if (function_holder_maker.has_value()) {
+ // all signatures should have the same base name, use the first
signature's base name
+ auto const& func_base_name = func.signatures().begin()->base_name();
+ ARROW_RETURN_NOT_OK(holder_maker_registry_.Register(
+ func_base_name, std::move(function_holder_maker.value())));
+ }
+ c_functions_.emplace_back(func, c_function_ptr);
+ ARROW_RETURN_NOT_OK(FunctionRegistry::Add(std::move(func)));
+ return Status::OK();
Review Comment:
Good catch. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
