niyue commented on code in PR #38632: URL: https://github.com/apache/arrow/pull/38632#discussion_r1389147440
########## cpp/src/gandiva/expr_decomposer.cc: ########## @@ -25,11 +25,12 @@ #include "gandiva/annotator.h" #include "gandiva/dex.h" -#include "gandiva/function_holder_registry.h" +#include "gandiva/function_holder_maker_registry.h" #include "gandiva/function_registry.h" #include "gandiva/function_signature.h" #include "gandiva/in_holder.h" #include "gandiva/node.h" +#include "gandiva/regex_functions_holder.h" Review Comment: I found `LikeHolder` is used below but its header is not included so I added it (it is likely included indirectly by other header files ). Let me know if this is not recommended in the project (if not included, I ran into some issues in other projects, during refactoring, a indirectly included header file was removed, and causing the other file failed to be compiled) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
