jayzhan211 commented on code in PR #8142:
URL: https://github.com/apache/arrow-datafusion/pull/8142#discussion_r1390397949
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -563,13 +563,42 @@ pub fn array_slice(args: &[ArrayRef]) -> Result<ArrayRef>
{
define_array_slice(list_array, key, extra_key, false)
}
+fn general_array_pop(
+ list_array: &GenericListArray<i32>,
+ from_back: bool,
+) -> Result<(Vec<i64>, Vec<i64>)> {
+ if from_back {
Review Comment:
nit: Since there is no common for back and front, I dont think we need to
write them together, but that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
