Veeupup commented on PR #8142:
URL: 
https://github.com/apache/arrow-datafusion/pull/8142#issuecomment-1810197721

   > Thanks @Veeupup Please more tests with nulls and empty arrays, please try 
to think up any possible case to prevent bug to flow in.
   > 
   > And since new built in function gets introduced we need to get this 
documented in `scalar_functions.md` and `expressions.md`
   
   very thanks for your advice! docs have been added!
   
   and the test for empty and NULL has already added, and you can check [empty 
array 
test](https://github.com/apache/arrow-datafusion/pull/8142/files#diff-317c67cc9ce87268e4ccec1cb75316eed82f99ae2ffc226874e5897913ffa4c8R838)
 and [NULL value 
test](https://github.com/apache/arrow-datafusion/pull/8142/files#diff-317c67cc9ce87268e4ccec1cb75316eed82f99ae2ffc226874e5897913ffa4c8R850).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to