jayzhan211 commented on PR #8142: URL: https://github.com/apache/arrow-datafusion/pull/8142#issuecomment-1807123963
> > @Veeupup Would you like to try rewriting array_pop_front / back with MutableArrayData? I think it will be much easier to understand than the current slice! and list_slice! macros. > > yeah, agree with you.. to understand what slice! macro does cost me some time.. > > but this macro has been used for some other functions and for now implementation with `slice!` maybe the simplest way to do with it? If you also spend much time on slice!, it is a good reason for us to improve on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
