bkietz commented on code in PR #38027:
URL: https://github.com/apache/arrow/pull/38027#discussion_r1391355506
##########
cpp/src/arrow/array/data.h:
##########
@@ -434,6 +434,21 @@ struct ARROW_EXPORT ArraySpan {
return GetValues<T>(i, this->offset);
}
+ // Access a buffer's data as a span
+ template <typename T>
+ util::span<const T> GetSpan(int i) const {
+ return util::span(buffers[i].data_as<T>(),
+ static_cast<size_t>(buffers[i].size) / sizeof(T))
+ .subspan(offset);
Review Comment:
I'm not sure why, but clang-10 is failing to recognize span as a struct.
https://github.com/apache/arrow/actions/runs/6832493029/job/18583237204?pr=38027#step:7:1342
Could you please rewrite this minimally with a local span and explicit
template arguments to see if that satisfies clang-10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
