felipecrv commented on code in PR #38027:
URL: https://github.com/apache/arrow/pull/38027#discussion_r1391683834
##########
cpp/src/arrow/array/data.h:
##########
@@ -434,6 +434,21 @@ struct ARROW_EXPORT ArraySpan {
return GetValues<T>(i, this->offset);
}
+ // Access a buffer's data as a span
+ template <typename T>
+ util::span<const T> GetSpan(int i) const {
+ return util::span(buffers[i].data_as<T>(),
+ static_cast<size_t>(buffers[i].size) / sizeof(T))
+ .subspan(offset);
+ }
+
+ template <typename T>
+ util::span<T> GetSpan(int i) {
+ return util::span(buffers[i].mutable_data_as<T>(),
+ static_cast<size_t>(buffers[i].size) / sizeof(T))
+ .subspan(offset);
Review Comment:
Should this length be the array length instead? Considering that it's
possible (I believe) to have buffers that are longer than
`(offset+length)*sizeof(T)`?
@bkietz @pitrou what are the invariants followed by the buffer lengths for
valid arrays? Are they always perfectly sliced to fit `offset+length` values or
can they be longer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
