aiguofer commented on code in PR #38733:
URL: https://github.com/apache/arrow/pull/38733#discussion_r1395938808
##########
java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/converter/impl/FixedSizeListAvaticaParameterConverter.java:
##########
@@ -33,6 +37,33 @@ public
FixedSizeListAvaticaParameterConverter(ArrowType.FixedSizeList type) {
@Override
public boolean bindParameter(FieldVector vector, TypedValue typedValue, int
index) {
+ final List<?> values = (List<?>) typedValue.value;
+
+ if (vector instanceof FixedSizeListVector) {
+ FixedSizeListVector listVector = ((FixedSizeListVector) vector);
+ FieldVector childVector = listVector.getDataVector();
+ if (values.size() > listVector.getListSize()) {
Review Comment:
I guess it depends on intended behavior. I was thinking you can have less
items and they'll just get padded with `null` if missing. I jus realized I
should also check if nullable for that case.
How are `FixedSizeListVectors` generally used? I can change it to a strict
check or add the nullability check to see if it can hold less items.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
