aiguofer commented on code in PR #38733:
URL: https://github.com/apache/arrow/pull/38733#discussion_r1395976591
##########
java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/converter/impl/FixedSizeListAvaticaParameterConverter.java:
##########
@@ -33,6 +37,33 @@ public
FixedSizeListAvaticaParameterConverter(ArrowType.FixedSizeList type) {
@Override
public boolean bindParameter(FieldVector vector, TypedValue typedValue, int
index) {
+ final List<?> values = (List<?>) typedValue.value;
+
+ if (vector instanceof FixedSizeListVector) {
+ FixedSizeListVector listVector = ((FixedSizeListVector) vector);
+ FieldVector childVector = listVector.getDataVector();
+ if (values.size() > listVector.getListSize()) {
Review Comment:
For any vector, if you set value count to more items than you've actually
set, the rest just get set to `null` right? when we set the listvector's value
count it handles setting the value count on the child vector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
