lidavidm commented on code in PR #38733:
URL: https://github.com/apache/arrow/pull/38733#discussion_r1395955882


##########
java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/converter/impl/FixedSizeListAvaticaParameterConverter.java:
##########
@@ -33,6 +37,33 @@ public 
FixedSizeListAvaticaParameterConverter(ArrowType.FixedSizeList type) {
 
   @Override
   public boolean bindParameter(FieldVector vector, TypedValue typedValue, int 
index) {
+    final List<?> values = (List<?>) typedValue.value;
+
+    if (vector instanceof FixedSizeListVector) {
+      FixedSizeListVector listVector = ((FixedSizeListVector) vector);
+      FieldVector childVector = listVector.getDataVector();
+      if (values.size() > listVector.getListSize()) {

Review Comment:
   We can pad, but I'm not sure if the vector does that for you or if you have 
to explicitly pad...
   
   I'm not sure they'd be used much/at all in this context



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to