jhorstmann opened a new pull request, #5100:
URL: https://github.com/apache/arrow-rs/pull/5100
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #5031 and closes #5032.
# Rationale for this change
The explicit simd aggregation kernels added a lot of complexity and made it
difficult to support the total order relation for floating point min/max.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
- Refactor the sum/min/max kernels to rely on autovectorization
- Remove the explicit simd aggregation kernels
- Change min/max for floating point numbers to follow the total order
relation
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
The behavior of min/max changed to follow the total order relation, which
differs from the previously implemented ordering for negative zero and negative
NaN. Negative NaN will now compare as smaller than any other numbers,
previously any NaN was considered bigger than any non-NaN number.
The `ArrowNumericType` methods enabled with the `simd` feature are now
unused, but I kept them in the code for now. The could be removed or marked as
deprecated in a followup PR.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
