comphead commented on PR #8193: URL: https://github.com/apache/arrow-datafusion/pull/8193#issuecomment-1819663751
@alamb I have aligned signatures, the solution is still suboptimal(using 2 casts). In followup PR I would get rid of 2 casts and we need to support extreme low and high integer values, currently it overflows because Timestamp backed by `i64` which is supposed to be microsecond rather than nanosecond. I see 2 options to handle this: - Have a default precision as a microsecond(now its nanosecond), imho its preferred as PG or other major engines have a microsecond precision - Modify underlying value type for Timestamp from `i64` to `i128` @alamb let me know your thoughts. PS. Not sure why clippy failed... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
